DistanceFromAllTimeHighColumn: Add tooltip with info about ATH #4225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
pfalcon
commented
Sep 13, 2024
pfalcon
commented
|
Discussion about ColumnWithOptionLabelProvider: #4224 |
pfalcon
force-pushed
the
ath-tooltip
branch
from
27fcfb4
to
3b112ed
Compare
…ith option Existing OptionLabelProvider provides overloaded methods like getText() which take additional "option" param. However, it supports only subset of methods, e.g. it doesn't support tooltips via getToolTipText(), etc. ColumnWithOptionLabelProvider takes another approach - instead of "pushing" option value via overloaded method signatures, it offers a "pull" approach of calling getOption() method within any of existing methods, thus supporting tooltips, etc. (Underlying implementation is that reference to concrete TableColumn is still pushed down a specific OptionLabelProvider instance).
Show tooltip with absolute value of ATH and its date. To support tooltip, switch to ColumnWithOptionLabelProvider.
pfalcon
force-pushed
the
ath-tooltip
branch
from
3b112ed
to
2a2a8a4
Compare
buchen
reviewed
Sep 17, 2024
|
|
||
| public void setTableColumn(TableColumn tableColumn) | ||
| { | ||
| this.tableColumn = tableColumn; |
There was a problem hiding this comment.
That is a nice idea. It will simplify. I just wonder if we should throw an exception if the tableColumn is already set. Then developers get an obvious hint if they re-use label provider (instead of using the factory method).
Anyway, will merge when I am back at my development machine.
buchen
added a commit
that referenced
this pull request
Sep 21, 2024
|
merged. |
buchen
added a commit
that referenced
this pull request
Sep 23, 2024
This was referenced Oct 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.