Added changes for resource transformation feature #215
Conversation
Signed-off-by: Lalatendu Das <ldas@purestorage.com>
lalat-das
requested review from
prashanthpx,
siva-portworx and
diptiranjanpx
|
OSS Scan Results:
Total issues: 1 |
|
License Evaluation Results:
Total License Issues: 0 |
| message ResourceTransformTemplate { | ||
| // Resource is GroupVersionKind for k8s resources | ||
| // should be in format `group/version/kind" | ||
| //ResourceType string `json:"resource"` |
There was a problem hiding this comment.
remove the above line. Do we need json tag mentioned in the comment?
| @@ -876,6 +932,120 @@ message SchedulePolicyOwnershipUpdateRequest { | |||
|
|
|||
| message SchedulePolicyOwnershipUpdateResponse {} | |||
|
|
|||
| service ResourceTransform { | |||
| // Creates new schedule policy. | |||
There was a problem hiding this comment.
Please correct comments in all the API.
schedule policy --> ResourceTransform
| map<string, string> labels = 2; | ||
| } | ||
| // Define ResourceTransformEnumerateResponse struct | ||
|
|
There was a problem hiding this comment.
typo: Remove extra empty line between comment and def
| ResourceTransformOpsType resource_transform_ops_type = 3; | ||
| // Operation to be performed on path | ||
| // add/modify/delete/replace/jsonPatch | ||
| ResourceTransformValueType resource_transfor_value_type = 4; |
There was a problem hiding this comment.
typo: resource_transfor_value_type -> resource_transform_value_type
| string Path = 1; | ||
| // Value for given k8s path | ||
| string value = 2; | ||
| // Type of value specified int/bool/string/slice/keypair |
There was a problem hiding this comment.
Looks like the comment of resource_transform_ops_type and resource_transfor_value_type are interchanged
| // stores all the stand alone resource transformation rules which are not part any predefined resource transformation template yet | ||
| repeated ResourceTransformTemplate resource_transform_templates = 24; | ||
| // stores array of predefined resource transformation template fed during restore | ||
| repeated ObjectRef resource_transformation_ref = 25; |
There was a problem hiding this comment.
Are we planning to support more one resourceTransform object reference in a restore object? Why it has to be an array?
What this PR does / why we need it: This adds necessary data-structure and api.proto changes for resource transformation feature
Which issue(s) this PR fixes (optional)
Closes # pb-4427
Special notes for your reviewer:
make proto succeeds
