-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pb-6910: preserve uid & gid with which volume is backed up #243
Conversation
OSS Scan Results:
Total issues: 43 |
License Evaluation Results:
Total License Issues: 0 |
pkg/apis/v1/api.proto
Outdated
@@ -585,6 +585,10 @@ message BackupInfo { | |||
string pvc_id = 12; | |||
string provisioner = 13; | |||
string volumesnapshot = 14; | |||
// if as part of restrictive PSA setting, an UID or GID is used | |||
// during backup then same value should be used during restore operation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isnt this mostly for inplace restore to same namespace on same cluster? How does this apply for new cluster ? UID and GID would not be same.
0dfd005
to
a8647fa
Compare
OSS Scan Results:
Total issues: 43 |
License Evaluation Results:
Total License Issues: 0 |
a8647fa
to
3e19305
Compare
3e19305
to
ad05f42
Compare
OSS Scan Results:
Total issues: 43 |
License Evaluation Results:
Total License Issues: 0 |
- During backup due to restricted PSA enforcement the app must use certain uid and gid. - Same uid/gid need to be used to restore volume while using a JOB-POD to achieve the same. Signed-off-by: Lalatendu Das <ldas@purestorage.com>
ad05f42
to
607bbb9
Compare
OSS Scan Results:
Total issues: 43 |
License Evaluation Results:
Total License Issues: 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
During backup due to restricted PSA the app will use certain uid and gid. Same uid Gid need to be used to restore while using a JOB-POD.
What this PR does / why we need it: During backup due to restricted PSA the app will use certain uid and gid. Same uid Gid need to be used to restore while using a JOB-POD.
Which issue(s) this PR fixes (optional)
Closes # pb-6910
Special notes for your reviewer: