Read profile and group from Matchbox to detect drift #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nick-Triller
force-pushed
the
improve-read
branch
from
746bdcf to
4918f53
Compare
Nick-Triller
force-pushed
the
improve-read
branch
from
4918f53 to
0baaaef
Compare
|
Rebased on master |
|
Hi @dghubble, |
|
Maybe in a bit, I haven't had a need for it yet but I appreciate it |
dghubble
changed the title
|
Rebased as 010a7d2, thanks |
dghubble
added a commit
that referenced
this pull request
Jul 30, 2022
* Fix "unexpected end of JSON input" error when planning or applying after a matchbox_group without metadata is created (a common case) * Group metadata is returned as an empty []byte, so its not valid to try to parse it as JSON * Add test coverage and improve testing in general Regressed by #68
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
currently, terraform-provider-matchbox does not refresh state except when a resource was deleted in Matchbox. The provider always compares the original tfstate with the desired state without taking into account if the content of a resource in Matchbox changed. Consequently, deleting a group / profile / template and recreating it with different content but the same name outside of Terraform can't be detected.
This PR ensures refresh works as expected.
Best
Nick