Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore controller user_data changes to allow plugin updates #335

Merged
merged 1 commit into from
Oct 29, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion CHANGES.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@ Notable changes between versions.
* Update Calico from v3.2.3 to [v3.3.0](https://docs.projectcalico.org/v3.3/releases/)
* Disable Kubelet read-only port ([#324](https://github.com/poseidon/typhoon/pull/324))
* Fix CoreDNS AntiAffinity spec to prefer spreading replicas
* Ignore controller node user-data changes ([#335](https://github.com/poseidon/typhoon/pull/335))
* Once all managed clusters use v1.12.2, it is possible to update `terraform-provider-ct`

#### AWS

Expand All @@ -29,7 +31,7 @@ Notable changes between versions.

#### Google Cloud

* Add an IPv6 address and IPv6 forwarding rules for load balancing IPv6 Ingress
* Add an IPv6 address and IPv6 forwarding rules for load balancing IPv6 Ingress ([#334](https://github.com/poseidon/typhoon/pull/334))
* Add `ingress_static_ipv6` output variable for use in AAAA DNS records
* Allow serving IPv6 applications via Kubernetes Ingress

Expand Down
5 changes: 4 additions & 1 deletion aws/container-linux/kubernetes/controllers.tf
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,10 @@ resource "aws_instance" "controllers" {
vpc_security_group_ids = ["${aws_security_group.controller.id}"]

lifecycle {
ignore_changes = ["ami"]
ignore_changes = [
"ami",
"user_data",
]
}
}

Expand Down
5 changes: 4 additions & 1 deletion aws/fedora-atomic/kubernetes/controllers.tf
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,10 @@ resource "aws_instance" "controllers" {
vpc_security_group_ids = ["${aws_security_group.controller.id}"]

lifecycle {
ignore_changes = ["ami"]
ignore_changes = [
"ami",
"user_data",
]
}
}

Expand Down
1 change: 1 addition & 0 deletions azure/container-linux/kubernetes/controllers.tf
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,7 @@ resource "azurerm_virtual_machine" "controllers" {
lifecycle {
ignore_changes = [
"storage_os_disk",
"os_profile",
]
}
}
Expand Down
6 changes: 6 additions & 0 deletions digital-ocean/container-linux/kubernetes/controllers.tf
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,12 @@ resource "digitalocean_droplet" "controllers" {
tags = [
"${digitalocean_tag.controllers.id}",
]

lifecycle {
ignore_changes = [
"user_data",
]
}
}

# Tag to label controllers
Expand Down
4 changes: 4 additions & 0 deletions digital-ocean/container-linux/kubernetes/workers.tf
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,10 @@ resource "digitalocean_droplet" "workers" {
tags = [
"${digitalocean_tag.workers.id}",
]

lifecycle {
create_before_destroy = true
}
}

# Tag to label workers
Expand Down
6 changes: 6 additions & 0 deletions digital-ocean/fedora-atomic/kubernetes/controllers.tf
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,12 @@ resource "digitalocean_droplet" "controllers" {
tags = [
"${digitalocean_tag.controllers.id}",
]

lifecycle {
ignore_changes = [
"user_data",
]
}
}

# Tag to label controllers
Expand Down
4 changes: 4 additions & 0 deletions digital-ocean/fedora-atomic/kubernetes/workers.tf
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,10 @@ resource "digitalocean_droplet" "workers" {
tags = [
"${digitalocean_tag.workers.id}",
]

lifecycle {
create_before_destroy = true
}
}

# Tag to label workers
Expand Down
6 changes: 6 additions & 0 deletions google-cloud/container-linux/kubernetes/controllers.tf
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,12 @@ resource "google_compute_instance" "controllers" {

can_ip_forward = true
tags = ["${var.cluster_name}-controller"]

lifecycle {
ignore_changes = [
"metadata",
]
}
}

# Controller Ignition configs
Expand Down
6 changes: 6 additions & 0 deletions google-cloud/fedora-atomic/kubernetes/controllers.tf
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,12 @@ resource "google_compute_instance" "controllers" {

can_ip_forward = true
tags = ["${var.cluster_name}-controller"]

lifecycle {
ignore_changes = [
"metadata",
]
}
}

# Controller Cloud-Init
Expand Down