Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ark: Issues with incomplete inputs in Jupyter apps #557

Closed
lionel- opened this issue Sep 19, 2024 · 1 comment · Fixed by #536
Closed

Ark: Issues with incomplete inputs in Jupyter apps #557

lionel- opened this issue Sep 19, 2024 · 1 comment · Fixed by #536
Assignees
Labels
area: jupyter kernel bug Something isn't working

Comments

@lionel-
Copy link
Contributor

lionel- commented Sep 19, 2024

When an incomplete prompt is detected and R needs more input, we reply with a ExecuteResponse::ReplyException. This should never be the case in Positron since we only send complete inputs, but this error is seen in Jupyter apps. There are currently a couple of issues:

  • We see a weird syntax error caused by the way we wrap inputs in braces to avoid printing intermediate expressions (ignore the INFO message):
Screenshot 2024-09-19 at 13 09 22
  • Once we fix this syntax error I'm pretty sure Ark will be in an unexpected state because we don't reset the REPL state and R is still waiting for more input to complete the current command. To fix this, we could try running invokeRestart("abort") (I'd rather not send an interrupt).
@DavisVaughan
Copy link
Contributor

I do see that incomplete is also an error on the python side

Screenshot 2024-09-19 at 8 20 56 AM

@DavisVaughan DavisVaughan transferred this issue from posit-dev/positron Oct 1, 2024
@lionel- lionel- added bug Something isn't working area: jupyter kernel labels Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: jupyter kernel bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants