-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split inputs by newlines #536
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lionel-
force-pushed
the
bugfix/split-input
branch
2 times, most recently
from
September 19, 2024 15:00
b46e79d
to
aa5c30a
Compare
lionel-
reviewed
Sep 23, 2024
lionel-
force-pushed
the
bugfix/split-input
branch
from
October 3, 2024 14:59
8578103
to
02e3feb
Compare
lionel-
reviewed
Oct 4, 2024
lionel-
force-pushed
the
bugfix/split-input
branch
from
October 4, 2024 11:21
c23cacf
to
ce475cd
Compare
Should only happen in Jupyter Notebooks. Positron should always check for complete inputs before sending them through.
Allowing us to manually throw an R error from the POD site
And add tests that its actually off during harp/ark `r_task()` tests and frontend integration tests
lionel-
force-pushed
the
bugfix/split-input
branch
from
October 4, 2024 11:28
ce475cd
to
adaf4e7
Compare
lionel-
force-pushed
the
bugfix/split-input
branch
from
October 4, 2024 12:35
e8f1aff
to
1255911
Compare
lionel-
force-pushed
the
bugfix/split-input
branch
from
October 4, 2024 13:18
e86027b
to
4f3f13b
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With @lionel-
Addresses posit-dev/positron#4745
Addresses posit-dev/positron#4742
Closes #557
Co-authored-by: Lionel Henry lionel@posit.co
Co-authored-by: Davis Vaughan davis@posit.co