Skip to content

Commit

Permalink
Enable web testing for smoke tests; bump slack reporter (#4775)
Browse files Browse the repository at this point in the history
Enable web testing for smoke tests; bump slack reporter.

Keep in mind that
[positron-license](https://github.com/posit-dev/positron-license) is
needed parallel to positron and it needs to be set up.

### QA Notes

All smoke tests should pass
Web smoke tests should be locally runnable
Slack reporter for workflow_dispatch should report branch
  • Loading branch information
testlabauto authored Sep 20, 2024
1 parent 7f6bbee commit 1279363
Show file tree
Hide file tree
Showing 4 changed files with 34 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/positron-full-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,7 @@ jobs:
if: ${{ failure() }}
steps:
- name: "Send Slack notification"
uses: testlabauto/action-test-results-to-slack@v0.0.4
uses: testlabauto/action-test-results-to-slack@v0.0.6
with:
github_token: ${{ secrets.POSITRON_GITHUB_PAT }}
slack_token: ${{ secrets.SMOKE_TESTS_SLACK_TOKEN }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/positron-merge-to-main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@ jobs:
if: ${{ failure() && needs.linux.outputs.target == 'smoketest-merge-to-main' }}
steps:
- name: 'Send Slack notification'
uses: testlabauto/action-test-results-to-slack@v0.0.4
uses: testlabauto/action-test-results-to-slack@v0.0.6
with:
github_token: ${{ secrets.POSITRON_GITHUB_PAT }}
slack_token: ${{ secrets.SMOKE_TESTS_SLACK_TOKEN }}
Expand Down
27 changes: 27 additions & 0 deletions .vscode/launch.json
Original file line number Diff line number Diff line change
Expand Up @@ -537,6 +537,33 @@
"VSCODE_CLI": "1"
}
},
{
"type": "node",
"request": "launch",
"name": "Launch Web Smoke Test",
"program": "${workspaceFolder}/test/smoke/test/index.js",
"cwd": "${workspaceFolder}/test/smoke",
"timeout": 240000,
"args": [
"--tracing",
"--web"
],
"outFiles": [
"${cwd}/out/**/*.js"
],
//---- Start Positron
"sourceMaps": true,
"resolveSourceMapLocations": [
"${workspaceFolder}/**",
"!**/node_modules/**"
],
//--- End Positron
"env": {
"NODE_ENV": "development",
"VSCODE_DEV": "1",
"VSCODE_CLI": "1"
}
},
{
"name": "Launch Built-in Extension",
"type": "extensionHost",
Expand Down
6 changes: 5 additions & 1 deletion test/automation/src/playwrightBrowser.ts
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,11 @@ async function launchServer(options: LaunchOptions) {
`--extensions-dir=${extensionsPath}`,
`--server-data-dir=${agentFolder}`,
'--accept-server-license-terms',
`--logsPath=${serverLogsPath}`
`--logsPath=${serverLogsPath}`,
// --- Start Positron ---
`--connection-token`,
`dev-token`
// --- End Positron ---
];

if (options.verbose) {
Expand Down

0 comments on commit 1279363

Please sign in to comment.