Skip to content

Commit

Permalink
Include missing files in reh-web binary (#4761)
Browse files Browse the repository at this point in the history
- Part of #4274
- Adds missing files to the includes: a new file (rsLoginCheck.js) from
Workbench via #4655 and the help.html help container page

### QA Notes

When running Positron in Workbench, there should be no server or dev
console errors around missing these files. Positron should load in
Workbench.

---------

Signed-off-by: sharon <sharon-wang@users.noreply.github.com>
Co-authored-by: sharon wang <25834218+sharon-wang@users.noreply.github.com>
  • Loading branch information
sharon-wang and sharon-wang authored Sep 20, 2024
1 parent 7f99658 commit 6af0b2c
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 0 deletions.
1 change: 1 addition & 0 deletions build/gulpfile.reh.js
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,7 @@ const BUILD_TARGETS = [
const serverResourceIncludes = [
// --- Start Positron ---
'out-build/react-dom/client.js',
'out-build/vs/code/browser/workbench/rsLoginCheck.js',
// --- End Positron ---

// NLS
Expand Down
10 changes: 10 additions & 0 deletions build/gulpfile.vscode.web.js
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,11 @@ const vscodeWebResourceIncludes = isESM() ? [
// Webview
'out-build/vs/workbench/contrib/webview/browser/pre/*.{js,html}',

// --- Start Positron ---
// Positron Help
'out-build/vs/workbench/contrib/positronHelp/browser/resources/help.html',
// --- End Positron ---

// Tree Sitter highlights
'out-build/vs/editor/common/languages/highlights/*.scm',

Expand All @@ -77,6 +82,11 @@ const vscodeWebResourceIncludes = isESM() ? [
'out-build/vs/workbench/contrib/webview/browser/pre/*.js',
'out-build/vs/workbench/contrib/webview/browser/pre/*.html',

// --- Start Positron ---
// Positron Help
'out-build/vs/workbench/contrib/positronHelp/browser/resources/help.html',
// --- End Positron ---

// Extension Worker
'out-build/vs/workbench/services/extensions/worker/webWorkerExtensionHostIframe.html',

Expand Down

0 comments on commit 6af0b2c

Please sign in to comment.