Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python: use Python Environment Tools (PET) for interpreter discovery #5886

Open
isabelizimm opened this issue Jan 6, 2025 · 0 comments
Open

Python: use Python Environment Tools (PET) for interpreter discovery #5886

isabelizimm opened this issue Jan 6, 2025 · 0 comments
Assignees
@isabelizimm
Labels
area: environment Issues related to Environment category. lang: python
Milestone
2025.02.0 Pre-Rel...

Comments

@isabelizimm
Copy link
Contributor

Recently, upstream vscode-python has moved from an in-extension Python interpreter discovery to a Rust based toolkit called Python Environment Tools. We would like to use these tools as well. We already have the code in place to run this locator from upstream merges, but the capability is currently turned off.

Upstream checks out pet in CI and the rust toolchain setup.

Related PR where pet is implemented as main locator.
@isabelizimm isabelizimm added area: environment Issues related to Environment category. lang: python labels Jan 6, 2025
@isabelizimm isabelizimm added this to the 2025.02.0 Pre-Release milestone Jan 6, 2025
@isabelizimm isabelizimm self-assigned this Jan 6, 2025
@isabelizimm isabelizimm mentioned this issue Jan 7, 2025
Merged
2 tasks
isabelizimm added a commit that referenced this issue Jan 31, 2025
@isabelizimm
python: use Python Environment Tools for interpreter discovery (#5897)
21a4d6b 
<!-- Thank you for submitting a pull request.
If this is your first pull request you can find information about
contributing here:
  * https://github.com/posit-dev/positron/blob/main/CONTRIBUTING.md

We recommend synchronizing your branch with the latest changes in the
main branch by either pulling or rebasing.
-->

<!--
  Describe briefly what problem this pull request resolves, or what
  new feature it introduces. Include screenshots of any new or altered
  UI. Link to any GitHub issues but avoid "magic" keywords that will
  automatically close the issue. If there are any details about your
  approach that are unintuitive or you want to draw attention to, please
  describe them here.
-->


### Release Notes

<!--
Optionally, replace `N/A` with text to be included in the next release
notes.
The `N/A` bullets are ignored. If you refer to one or more Positron
issues,
these issues are used to collect information about the feature or
bugfix, such
as the relevant language pack as determined by Github labels of type
`lang: `.
  The note will automatically be tagged with the language.

These notes are typically filled by the Positron team. If you are an
external
  contributor, you may ignore this section.
-->

#### New Features

- Install and compile Python Environment Tools, a Rust-based interpreter
discovery system #5886

#### Bug Fixes

- N/A


### QA Notes

<!--
  Add additional information for QA on how to validate the change,
  paying special attention to the level of risk, adjacent areas that
  could be affected by the change, and any important contextual
  information not present in the linked issues.
-->

Should be able to locate interpreters/start up Python runtimes with
setting `"python.locator": "native"`

---

TODO

- [x] re-enable native locator tests
- [x] add steps into build CI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@isabelizimm isabelizimm

Labels
area: environment Issues related to Environment category. lang: python
Projects
None yet
Milestone
2025.02.0 Pre-Release
Development

No branches or pull requests
1 participant
@isabelizimm