-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix R help url resolution on Server Web and Workbench #4814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(need to access the web client on a different host than the server to check this)
kind of works, but not when navigating to other help pages
This reverts commit 1f16dd0.
the external uri resolution already takes place in positronProxy, so we don't need to worry about it inthe positronHelpService
softwarenerd
approved these changes
Sep 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implementation Notes
/
) with the proxied path, so that those resources are loaded from the correct location\
in instances ofsrc="\
andhref="\
with the proxyPathQA Notes
In Positron Server Web and Positron on Workbench:
?iris
and hit Enter404 Not Found
errors in the Developer Console or Network tab for paths referenced in the help HTMLThe Help Pane in Positron Desktop should continue to work.
Note that Python help issues on Server Web and Workbench are not addressed in this PR.