Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e-test: improve handling of open folder options #6331

Merged
merged 2 commits into from
Feb 13, 2025
Merged

Conversation

midleman
Copy link
Contributor

@midleman midleman commented Feb 13, 2025

Summary

So I previously just fixed this, but I didn't account for the fact that in CI full test suite runs specifically there are A LOT of temp dirs, therefore the max of 50 options (which I had set) is not enough. Rather than extending that, I opted to type each dir of the path sequentially and wait for list to load.

QA Notes

Running full suite to confirm all is well.

@:r-pkg-development @:test-explorer

Copy link

github-actions bot commented Feb 13, 2025

E2E Tests 🚀
This PR will run tests tagged with: @:critical @:r-pkg-development @:test-explorer

readme  valid tags

@midleman midleman marked this pull request as ready for review February 13, 2025 00:29
Copy link
Contributor

@jonvanausdeln jonvanausdeln left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@midleman midleman merged commit 8fd9c45 into main Feb 13, 2025
16 checks passed
@midleman midleman deleted the mi/open-folder-fix branch February 13, 2025 01:14
@github-actions github-actions bot locked and limited conversation to collaborators Feb 13, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants