Skip to content

Commit

Permalink
Merge pull request kubernetes#56982 from tianshapjq/correct-annotatio…
Browse files Browse the repository at this point in the history
…ns-container_manager.go

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

correct a comment in container_manager.go

I just found the annotations doesn't match the func and I correct it.
correct me if i'm wrong :)
  • Loading branch information
Kubernetes Submit Queue committed Dec 18, 2017
2 parents 6b03a43 + 7a43f73 commit d3a7347
Showing 1 changed file with 1 addition and 5 deletions.
6 changes: 1 addition & 5 deletions pkg/kubelet/cm/container_manager.go
Original file line number Diff line number Diff line change
Expand Up @@ -122,11 +122,7 @@ type Status struct {
SoftRequirements error
}

// containerManager for the kubelet is currently an injected dependency.
// We need to parse the --qos-reserve-requests option in
// cmd/kubelet/app/server.go and there isn't really a good place to put
// the code. If/When the kubelet dependency injection gets worked out,
// maybe there will be a better place for it.
// parsePercentage parses the percentage string to numeric value.
func parsePercentage(v string) (int64, error) {
if !strings.HasSuffix(v, "%") {
return 0, fmt.Errorf("percentage expected, got '%s'", v)
Expand Down

0 comments on commit d3a7347

Please sign in to comment.