Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for messages length before logging. #257

Merged
merged 2 commits into from
Jan 4, 2019
Merged

Check for messages length before logging. #257

merged 2 commits into from
Jan 4, 2019

Conversation

XhmikosR
Copy link
Contributor

@XhmikosR XhmikosR commented Jan 4, 2019

Fixes #256

It doesn't seem to be tests for this, so I hope this doesn't break anything inadvertently.

/CC @RyanZim

@coveralls
Copy link

coveralls commented Jan 4, 2019 •
edited
Loading

Coverage Status

Coverage decreased (-0.4%) to 75.342% when pulling 74cc874 on XhmikosR:master into afdc65f on postcss:master.

RyanZim
RyanZim reviewed Jan 4, 2019
View reviewed changes
index.js Outdated Show resolved Hide resolved
@postcss postcss deleted a comment from coveralls Jan 4, 2019
@RyanZim RyanZim added the bug label Jan 4, 2019
@XhmikosR
Copy link
Contributor Author

XhmikosR commented Jan 4, 2019

@RyanZim: please check the second patch and let me know.

@RyanZim RyanZim merged commit 8c0a465 into postcss:master Jan 4, 2019
@RyanZim
Copy link
Collaborator

RyanZim commented Jan 4, 2019

Published in v5.1.1 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RyanZim RyanZim RyanZim left review comments

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@XhmikosR @coveralls @RyanZim