Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid joining void paths by passing cwd to the globber #262

Closed
wants to merge 1 commit into from
Closed

Avoid joining void paths by passing cwd to the globber #262

wants to merge 1 commit into from

Conversation

manuelmazzuola
Copy link

fix #261

@coveralls
Copy link

Coverage Status

Coverage remained the same at 75.342% when pulling 54224bf on ClouDesire:glob-issue into f2aba49 on postcss:master.

@postcss postcss deleted a comment from coveralls Jan 9, 2019
@RyanZim
Copy link
Collaborator

RyanZim commented Jan 9, 2019

According to https://github.com/mrmlnc/fast-glob#cwd; the default is already process.cwd(), so I'm not seeing what this changes?

@manuelmazzuola
Copy link
Author

I don't know but without this change postcss-cli doesn't work for me.
I have postcss-cli 6.1.1, node 10.15.0 and fast-glob 2.2.4 🤷‍♂️

@manuelmazzuola
Copy link
Author

You mentioned fast-glob but according to the package.json postcss-cli uses globby based on fast-glob, and look at this diff, commited 5 hours ago: sindresorhus/globby@d804228#diff-168726dbe96b3ce427e7fedce31bb0bcL50

@RyanZim
Copy link
Collaborator

RyanZim commented Jan 9, 2019

Trying doing a fresh install of postcss-cli, so you get globby 8.0.2, and see if that fixes your issue. Refs sindresorhus/globby#99 (comment).

@manuelmazzuola
Copy link
Author

They have fixed so I'll close this one.

@manuelmazzuola manuelmazzuola deleted the glob-issue branch January 10, 2019 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The "path" argument must be of type string. Received type undefined
3 participants