Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cosmiconfig to the latest version 🚀 #159

Closed
wants to merge 1 commit into from

Conversation

greenkeeper[bot]
Copy link
Contributor

@greenkeeper greenkeeper bot commented Aug 9, 2018

Version 5.0.6 of cosmiconfig was just published.

Dependency cosmiconfig
Current Version 4.0.0
Type dependency

The version 5.0.6 is not covered by your current version range.

If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.

It might be worth looking into these changes and trying to get this project onto the latest version of cosmiconfig.

If you have a solid test suite and good coverage, a passing build is a strong indicator that you can take advantage of these changes directly by merging the proposed change into your project. If the build fails or you don’t have such unconditional trust in your tests, this branch is a great starting point for you to work on the update.


Commits

The new version differs by 38 commits.

  • 5995949 Prepare 5.0.6
  • 5658ffc fix: no loader error for unsupported extension (#153)
  • 5ce57f0 Prepare 5.0.5
  • ef4a26f Add changelog entry for relative load fix.
  • 3e68a30 fix: Support loading JS config from relative paths (#147)
  • f849e51 Codecov integration and badge (#146)
  • 6106aec Prepare 5.0.4
  • b8c4464 Changelog entry and doc tweaks for rc file with .js extension
  • bdc4eac bring back support for 'js' rc extension (#144) (#145)
  • fa5f52e Prepare 5.0.3
  • 930ef40 fix code examples in readme (#142)
  • 0b96b52 chore: use yarn cache
  • f6b251d chore: clone last 5 commits
  • 2b3498b chore: add Node.js 4 and 6
  • b4e4dcc chore: add Node.js 8 and 10

There are 38 commits in total.

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.


Your Greenkeeper bot 🌴

@michael-ciniawsky michael-ciniawsky deleted the greenkeeper/cosmiconfig-5.0.6 branch August 9, 2018 18:08
@billyjanitsch
Copy link

Hi @michael-ciniawsky! I'm curious why this and #142 were closed. Are there no plans to upgrade the version of cosmiconfig used by postcss-load-config in the long term?

@michael-ciniawsky
Copy link
Collaborator

I need to do it manually in this case, and there were some concerns about caching and potential breakage with v5.0.0 due to direct require usage (require.cache) (webpack webpack/webpack#6929 (comment) (towards the end))

Note that cosmiconfig is already at version 5, but this seem to be unusable because of this bug: cosmiconfig/cosmiconfig#148. This would break watching the config file.

I'm honestly not sure if these claims are valid, but I opted for v4.0.0 for now. Is there anything causing (you) issues with v4.0.0 atm ? Long-term I will of course update the dependency :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants