Skip to content

Commit

Permalink
Do not import the whole lodash
Browse files Browse the repository at this point in the history
  • Loading branch information
ai committed Sep 15, 2020
1 parent c4826d3 commit 292a10f
Show file tree
Hide file tree
Showing 5 changed files with 42 additions and 10 deletions.
4 changes: 2 additions & 2 deletions lib/formatter.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
var { bold, underline, yellow } = require('colorette');
var path = require('path');
var symbols = require('log-symbols');
var _ = require('lodash');
var sortBy = require('lodash.sortby');
var util = require('./util');

module.exports = function(opts) {
Expand All @@ -17,7 +17,7 @@ module.exports = function(opts) {

if (!messages.length) return '';

var orderedMessages = _.sortBy(
var orderedMessages = sortBy(
messages,
function(m) {
if (!m.line) return 1;
Expand Down
12 changes: 7 additions & 5 deletions lib/reporter.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
var defaultFormatter = require('./formatter');
var { red, bold } = require('colorette');
var util = require('./util');
var _ = require('lodash');
var groupBy = require('lodash.groupby');
var forOwn = require('lodash.forown');
var difference = require('lodash.difference');

module.exports = function(opts = {}) {
var formatter = opts.formatter || defaultFormatter({
Expand Down Expand Up @@ -37,25 +39,25 @@ module.exports = function(opts = {}) {
var resultSource = (!result.root.source) ? ''
: result.root.source.input.file || result.root.source.input.id

var sourceGroupedMessages = _.groupBy(messagesToLog, message => {
var sourceGroupedMessages = groupBy(messagesToLog, message => {
return util.getLocation(message).file || resultSource;
});

var report = '';
_.forOwn(sourceGroupedMessages, function(messages, source) {
forOwn(sourceGroupedMessages, function(messages, source) {
report += formatter({
messages: messages,
source: source,
});
});

if (opts.clearReportedMessages) {
result.messages = _.difference(result.messages, messagesToLog);
result.messages = difference(result.messages, messagesToLog);
}

if (opts.clearAllMessages) {
var messagesToClear = result.messages.filter(pluginFilter);
result.messages = _.difference(result.messages, messagesToClear);
result.messages = difference(result.messages, messagesToClear);
}


Expand Down
4 changes: 2 additions & 2 deletions lib/util.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
var _ = require('lodash');
var get = require('lodash.get');

exports.getLocation = function(message) {
var messageNode = message.node;
Expand All @@ -8,7 +8,7 @@ exports.getLocation = function(message) {
column: message.column,
};

var messageInput = _.get(messageNode, 'source.input');
var messageInput = get(messageNode, 'source.input');

if (!messageInput) return location;

Expand Down
7 changes: 6 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
"clean-publish": "^1.1.8",
"eslint": "7.9.0",
"less": "3.12.2",
"lodash": "^4.17.20",
"postcss": "^8.0.3",
"source-map": "0.7.3",
"strip-color": "^0.1.0",
Expand All @@ -37,7 +38,11 @@
},
"dependencies": {
"colorette": "^1.2.1",
"lodash": "^4.17.20",
"lodash.difference": "^4.5.0",
"lodash.forown": "^4.4.0",
"lodash.get": "^4.4.2",
"lodash.groupby": "^4.6.0",
"lodash.sortby": "^4.7.0",
"log-symbols": "^4.0.0"
}
}
25 changes: 25 additions & 0 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -1650,6 +1650,31 @@ locate-path@^5.0.0:
dependencies:
p-locate "^4.1.0"

lodash.difference@^4.5.0:
version "4.5.0"
resolved "https://registry.yarnpkg.com/lodash.difference/-/lodash.difference-4.5.0.tgz#9ccb4e505d486b91651345772885a2df27fd017c"
integrity sha1-nMtOUF1Ia5FlE0V3KIWi3yf9AXw=

lodash.forown@^4.4.0:
version "4.4.0"
resolved "https://registry.yarnpkg.com/lodash.forown/-/lodash.forown-4.4.0.tgz#85115cf04f73ef966eced52511d3893cc46683af"
integrity sha1-hRFc8E9z75ZuztUlEdOJPMRmg68=

lodash.get@^4.4.2:
version "4.4.2"
resolved "https://registry.yarnpkg.com/lodash.get/-/lodash.get-4.4.2.tgz#2d177f652fa31e939b4438d5341499dfa3825e99"
integrity sha1-LRd/ZS+jHpObRDjVNBSZ36OCXpk=

lodash.groupby@^4.6.0:
version "4.6.0"
resolved "https://registry.yarnpkg.com/lodash.groupby/-/lodash.groupby-4.6.0.tgz#0b08a1dcf68397c397855c3239783832df7403d1"
integrity sha1-Cwih3PaDl8OXhVwyOXg4Mt90A9E=

lodash.sortby@^4.7.0:
version "4.7.0"
resolved "https://registry.yarnpkg.com/lodash.sortby/-/lodash.sortby-4.7.0.tgz#edd14c824e2cc9c1e0b0a1b42bb5210516a42438"
integrity sha1-7dFMgk4sycHgsKG0K7UhBRakJDg=

lodash@^4.17.14, lodash@^4.17.19, lodash@^4.17.20:
version "4.17.20"
resolved "https://registry.yarnpkg.com/lodash/-/lodash-4.17.20.tgz#b44a9b6297bcb698f1c51a3545a2b3b368d59c52"
Expand Down

0 comments on commit 292a10f

Please sign in to comment.