-
-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should also report errors by default #75
Conversation
Right now, we recommend to throwing errors by Do you have use case for messages for errors? |
oh interesting, I did not know of this method. My use case is to make a series of checks on a bundle (so Stylelint is not applicable here). I'm not interested in just reporting a single error at a time. |
Hm. In this case, we should throw some error from Maybe it is better to create your own custom plugin because we will need think a lot to create a good design for that for everyone. |
This is already handled here : https://github.com/postcss/postcss-reporter/blob/main/lib/reporter.js#L83-L89 although I am a bit puzzled that it would also throw on a |
In this case we should have thrown always on error and update docs to highlight that that option is about warnings. And change error message. |
I can add this to this PR (or a separate PR if you prefer) |
Let's have one feature PR where feature will be done to check the final design before merging |
sure! In the meantime is the current PR ok for you? |
It is hard to say, because in PR I look for overall changes. Let's finish all changes first. |
BTW, how we will format errors? |
ah okay, so I misunderstood what you said earlier, I'll add the changes to errors here as well. Currently, errors use the same behaviour as a warning, it's an entry with text, there isn't any stacktrace |
We don't need a stacktrace, but we need a different color and icon to separate them from warnings |
Indeed, I'll include that and make a proposal for that as well |
Looks amazing. I am going to release it today. |
This feature was released in 7.1. |
Awesome, thanks :) |
Hi, it seems that at some point ( 56a8e5a ) there was a change that hid
.type === "error"
reports.This is a surprising behaviour and definitely looks like a bug to me