Update cssesc to 3.0.0 #169
Conversation
1 similar comment
| t.deepEqual(attr.attribute, 'ng:foo'); | ||
| t.deepEqual(tree.toString(), '[ng\\3A foo]'); | ||
| t.deepEqual(tree.toString(), '[ng\\:foo]'); |
There was a problem hiding this comment.
hm, looks something invalid (title assign attribute name requiring escape), but now no escaping
There was a problem hiding this comment.
It's still escaped 👍 it's taking ng:foo and converting it to ng\:foo. Previously it was converting that to ng\3A foo but the : character only needs to be escaped that way in IE < 8. In IE9+ (and every other browser), it's safe to escape : as \:.
The main motivation for this change is to workaround the bug in css-loader (webpack-contrib/css-loader#578) where the leading slash is removed when it is followed by a hex character. This change is an attempt to make it possible to use as many non-standard characters as possible by not unnecessarily escaping : as \3A (which gets converted to 3A by css-loader) and instead escaping it as \: which css-loader leaves intact 👍
|
@jonathantneal should we release this as patch? |
|
I like this change. It requires a new major release because the maintainer of cssesc released it as a major release. I still think we should bring it in and look for any other major updates we can also take in. Even if there are no other major updates, because this update is straight-forward, I’m also fine to release this new version as-is. |
|
@jonathantneal hm, let's do it, can you take care? |
|
Yes. Thank you, @evilebottnawi for managing the issue and this PR. |
Closes #168