Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't alter HTML comments inside modules #17

Closed
maltsev opened this issue Feb 8, 2016 · 1 comment
Closed

Don't alter HTML comments inside modules #17

maltsev opened this issue Feb 8, 2016 · 1 comment
Labels
bug help wanted

Comments

@maltsev
Copy link
Member

maltsev commented Feb 8, 2016

None of the modules should alter regular HTML comments (except conditional comments).

For example, the module collapseWhitespaces alters HTML comments now.
@maltsev maltsev changed the title Don't alter regular HTML comments Don't alter regular HTML comments inside modules Feb 8, 2016
@maltsev maltsev mentioned this issue Feb 8, 2016
Closed
maltsev added a commit that referenced this issue Feb 9, 2016
@maltsev
Don't collapse whitespaces inside comments #17
a916e20
maltsev added a commit that referenced this issue Feb 9, 2016
@maltsev
Add some tests to prevent HTML comments altering inside modules #17
548ff59
@maltsev maltsev changed the title Don't alter regular HTML comments inside modules Don't alter HTML comments inside module Feb 9, 2016
@maltsev maltsev changed the title Don't alter HTML comments inside module Don't alter HTML comments inside modules Feb 9, 2016
@maltsev
Copy link
Member Author

maltsev commented Feb 9, 2016

Fixed: 0.1.3

@maltsev maltsev closed this as completed Feb 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@maltsev