Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ES6+ minification #48

Closed
elgs opened this issue Apr 17, 2018 · 2 comments
Closed

Fix ES6+ minification #48

elgs opened this issue Apr 17, 2018 · 2 comments

Comments

@elgs
Copy link

elgs commented Apr 17, 2018

Would you please take a look at this issue? Thanks!

parcel-bundler/parcel#1173
maltsev added a commit that referenced this issue Apr 17, 2018
@maltsev
Don't change <script> if JS minification failed #48
e8c1f19
maltsev added a commit that referenced this issue Apr 17, 2018
@maltsev
Replace uglify-js with uglify-es since it supports ES6 minification #48
4c273dd
@maltsev maltsev changed the title inline script is empty when minified Fix ES6+ minification Apr 17, 2018
@maltsev
Copy link
Member

maltsev commented Apr 17, 2018

Thanks for submitting the bug! I published new version 0.1.8 with the fix.

It was an issue with uglify-js, which is used internally to minify JS. It turned out that it doesn't support ES6+ minification. So I replaced it with uglify-es and now it seems to be working fine.

@maltsev maltsev closed this as completed Apr 17, 2018
@elgs
Copy link
Author

elgs commented Apr 17, 2018

Thank you, @maltsev!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@elgs @maltsev