Feat: removeAttributeQuotes #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SukkaW
commented
Oct 12, 2020
| @@ -26,6 +26,7 @@ export default { | |||
| removeEmptyAttributes: true, | |||
| removeRedundantAttributes: false, | |||
| removeComments: 'safe', | |||
| removeAttributeQuotes: false, | |||
There was a problem hiding this comment.
Although the feature is safe to enable (won't break anything), but it requires a completely rewritten for every existing unit test cases.
Since html-minifier doesn't enable the feature by default, I make it disabled in safe presets as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6
Implement a module that will be able to access and modify
tree.options.quoteAllAttributes.Notice it is not safe to changing
tree.optionsdirectly (although PostHTML Team doesn't think so). I have already discussed it with PostHTML Team (posthtml/posthtml#335). There should be a better approach.