Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "crossorigin" to boolean attributes #67

Merged
merged 1 commit into from
Dec 26, 2018
Merged

Conversation

fstanis
Copy link
Contributor

@fstanis fstanis commented Dec 26, 2018

An invalid keyword and an empty string will be handled as the anonymous keyword.

Source

@fstanis
Copy link
Contributor Author

fstanis commented Dec 26, 2018

This is an interesting case, technically crossorigin="anonymous" can always safely be replaced by crossorigin, so that's an additional optimization that htmlnano could also do, but that'd require adding special logic just for this attribute, which is probably not worth it.

@maltsev maltsev merged commit 0ead4d4 into posthtml:master Dec 26, 2018
@maltsev
Copy link
Member

maltsev commented Dec 26, 2018

Thanks for the PR!

@maltsev
Copy link
Member

maltsev commented Dec 26, 2018

that's an additional optimization that htmlnano could also do, but that'd require adding special logic just for this attribute, which is probably not worth it.

I think it's worth it. I created a new issue for that: #68.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants