Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: soft a check for rel attribute #45

Merged
merged 1 commit into from
Apr 20, 2024
Merged

fix: soft a check for rel attribute #45

merged 1 commit into from
Apr 20, 2024

Conversation

ZuBB
Copy link
Contributor

@ZuBB ZuBB commented Apr 20, 2024

The shortcut link type is deprecated as of now and is not recommended accordingly to MDN. To make a new version of the check work with old codebases we moved from an exact match strategy to a regex-based one.

PS: this will fix an issue we discovered in #44

The `shortcut` link type is deprecated as of now and is not recommended
accordingly to MDN. To make a new version of the check work with old
codebases we moved from an exact match strategy to a regex-based one.
@ZuBB ZuBB requested a review from metonym as a code owner April 20, 2024 06:28
Copy link
Collaborator

@metonym metonym left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ZuBB ZuBB mentioned this pull request Apr 20, 2024
@metonym metonym merged commit 91135eb into posthtml:master Apr 20, 2024
@ZuBB ZuBB deleted the drop-deprecated-link-type branch April 20, 2024 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants