Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ES5 #2

Closed
princed opened this issue Mar 21, 2016 · 6 comments
Closed

ES5 #2

princed opened this issue Mar 21, 2016 · 6 comments
Assignees
@Scrum
Labels
type: test

Comments

@princed
Copy link

princed commented Mar 21, 2016

Would you mind to merge a pull request with downgrade to ES5 to make this module compatible with older node.js versions?
@michael-ciniawsky
Copy link
Member

hi sry for the late reply no pull request are always welcome

princed added a commit to princed/posthtml-loader that referenced this issue May 6, 2016
@princed
Downgrade to ES5, closes posthtml#2
9a03e44
@Scrum
Copy link
Member

Scrum commented Jun 15, 2016

@princed actuality ?

@princed
Copy link
Author

princed commented Jun 15, 2016

Sure, merge it, please.

@michael-ciniawsky
Copy link
Member

Hi, ES5 compatibility should be given since 0.9. Sry this was my fault i oversaw the pull request back then, i will merge it in the 1.0 release in the next few days up ahead, but i'm currently finishing the autoloading options/plugins/presets plugins for posthtml, which will be part of the 1.0 release

@Scrum Scrum self-assigned this Jun 22, 2016
@Scrum Scrum added this to the 0.9.1 milestone Jun 22, 2016
@Scrum Scrum closed this as completed in 6783f2b Jun 23, 2016
@Scrum
Copy link
Member

Scrum commented Jun 23, 2016

@princed update and enjoy :)

@princed
Copy link
Author

princed commented Jun 27, 2016

@gitscrum Great, thanks!

@michael-ciniawsky michael-ciniawsky removed this from the 1.1.0 milestone Dec 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Scrum Scrum

Labels
type: test
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@princed @Scrum @michael-ciniawsky