Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix]: IE® conditional comments #9

Closed
stevenvachon opened this issue Mar 6, 2016 · 5 comments
Closed

[fix]: IE® conditional comments #9

stevenvachon opened this issue Mar 6, 2016 · 5 comments
Assignees
@Scrum
Labels
scope: htmlparser2 status: blocked type: bug

Comments

@stevenvachon
Copy link

stevenvachon commented Mar 6, 2016 •
edited
Loading

Downlevel-hidden, -revealed and bubbling, so that we can correctly parse this:

<html>
<!--[if lt IE 7]><html class="no-js ie6"><![endif]-->
<!--[if IE 7]><html class="no-js ie7"><![endif]-->
<!--[if IE 8]><html class="no-js ie8"><![endif]-->
<!--[if gt IE 8]><!--><html class="no-js"><!--<![endif]-->

(Not that I condone writing such filth)
@stevenvachon stevenvachon mentioned this issue Mar 6, 2016
Closed
@Scrum Scrum self-assigned this Nov 22, 2017
@Scrum Scrum changed the title IE® conditional comments [fix]: IE® conditional comments Dec 14, 2017
@Scrum Scrum added this to the 0.3.1 milestone Dec 14, 2017
@Scrum
Copy link
Member

Scrum commented Dec 15, 2017 •
edited
Loading

Hi @stevenvachon this related to:

I hope that you no longer use such constructions

@Scrum Scrum removed this from the 0.3.1 milestone Dec 15, 2017
@stevenvachon
Copy link
Author

@gitscrum cnn.com does

@Scrum Scrum mentioned this issue Mar 17, 2020
Closed
@SukkaW SukkaW mentioned this issue Nov 9, 2020
Closed
@SukkaW SukkaW mentioned this issue Nov 21, 2020
Merged
@SukkaW
Copy link

SukkaW commented Nov 23, 2020

Although it is possible to extract the content of the conditional comment and pass it back to postHtmlParser() again (just as I did in posthtml/htmlnano#119), however, the code snippet provided only has <html> start tag wrapped in a conditional comment, posthtml-render later will have to determine if </html> should be added. In posthtml/htmlnano#125 I have to manually remove </html> from result.html (kind of a dirty hack).

@Scrum
Copy link
Member

Scrum commented Nov 23, 2020

I thought the same, but it's very dirty

@SukkaW SukkaW mentioned this issue Nov 24, 2020
Closed
8 tasks
@Scrum
Copy link
Member

Scrum commented Aug 8, 2022

I think that it makes no sense to invest a resource in supporting something that is no longer supported.

Feel free to reopen the issue if you think it's a high priority and a must for you.

@Scrum Scrum closed this as completed Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Scrum Scrum

Labels
scope: htmlparser2 status: blocked type: bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@stevenvachon @voischev @Scrum @SukkaW