Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: minifyConditionalComments #119

Merged
merged 5 commits into from
Nov 12, 2020

Conversation

SukkaW
Copy link
Contributor

@SukkaW SukkaW commented Nov 9, 2020

The PR closes #16.

Comment on lines +11 to +12
// forEach, tree.walk, tree.match just don't support Promise.
for (let i = 0, len = tree.length; i < len; i++) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I mentioned in #16 (comment), tree.walk & tree.match is not designed to be work with Promise in the first place. Thus I use for loop to traverse through tree.

@SukkaW SukkaW force-pushed the minify-conditional-comments branch from 4b01af2 to ac53c2a Compare November 9, 2020 18:54
@maltsev maltsev merged commit 44ce503 into posthtml:master Nov 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Minify content inside conditional comments
2 participants