Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

frontend: fixes post preview and adds page preview #229

Merged
merged 1 commit into from
Sep 23, 2019

Conversation

mrclay
Copy link
Contributor

@mrclay mrclay commented Aug 18, 2019

No description provided.

@mrclay mrclay force-pushed the preview-fix branch 2 times, most recently from cb6e898 to c2cb546 Compare August 18, 2019 22:46
@mrclay mrclay changed the title Provide Preview.getInitialProps and handle other fetch errors frontend: fixes preview and adds page support Aug 18, 2019
@mrclay mrclay force-pushed the preview-fix branch 3 times, most recently from 0ecd8ff to e9af6b2 Compare August 18, 2019 23:00
@mrclay mrclay changed the title frontend: fixes preview and adds page support frontend: fixes post preview and adds page preview Aug 19, 2019
Copy link
Contributor

@magidmroueh magidmroueh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@magidmroueh magidmroueh merged commit e29b8e6 into postlight:master Sep 23, 2019
@mrclay mrclay deleted the preview-fix branch September 24, 2019 13:23
@renanbatel
Copy link

The preview link filtering doesn't work for draft posts on Gutenberg. You can use the workaround bellow as Gutenberg team hasn't fixed the issue yet. The snippet in the link doesn't cover all the situations but it's working here on our site for now.

WordPress/gutenberg#13998 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants