Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No module named 'imghdr' #2529

Closed
cherpake opened this issue Oct 22, 2024 · 6 comments · Fixed by #2532
Closed

No module named 'imghdr' #2529

cherpake opened this issue Oct 22, 2024 · 6 comments · Fixed by #2532
Labels

Comments

@cherpake
Copy link

Describe the bug

No module named 'imghdr'...
Seems it was deprecated and removed sphinx-doc/sphinx#10440

Error log

Traceback (most recent call last):
  File "/Users/cherpake/.local/bin/atvremote", line 5, in <module>
    from pyatv.scripts.atvremote import main
  File "/Users/cherpake/.local/pipx/venvs/pyatv/lib/python3.13/site-packages/pyatv/__init__.py", line 26, in <module>
    from pyatv.protocols import PROTOCOLS
  File "/Users/cherpake/.local/pipx/venvs/pyatv/lib/python3.13/site-packages/pyatv/protocols/__init__.py", line 10, in <module>
    from pyatv.protocols import airplay as airplay_proto
  File "/Users/cherpake/.local/pipx/venvs/pyatv/lib/python3.13/site-packages/pyatv/protocols/airplay/__init__.py", line 29, in <module>
    from pyatv.protocols.airplay.ap2_session import AP2Session
  File "/Users/cherpake/.local/pipx/venvs/pyatv/lib/python3.13/site-packages/pyatv/protocols/airplay/ap2_session.py", line 23, in <module>
    from pyatv.support.rtsp import RtspSession
  File "/Users/cherpake/.local/pipx/venvs/pyatv/lib/python3.13/site-packages/pyatv/support/rtsp.py", line 18, in <module>
    from pyatv.support.metadata import MediaMetadata
  File "/Users/cherpake/.local/pipx/venvs/pyatv/lib/python3.13/site-packages/pyatv/support/metadata.py", line 7, in <module>
    from mediafile import MediaFile
  File "/Users/cherpake/.local/pipx/venvs/pyatv/lib/python3.13/site-packages/mediafile.py", line 52, in <module>
    import imghdr
ModuleNotFoundError: No module named 'imghdr'

How to reproduce the bug?

Install python3.13

What is expected behavior?

Some kind of fix

Operating System

macOS

Python

Other

pyatv

latest

Device

any

Additional context

That's it

@cherpake cherpake added the bug label Oct 22, 2024
@postlund
Copy link
Owner

Bummer! Seems to be blocked by this:

beetbox/mediafile#67

@cherpake
Copy link
Author

cherpake commented Oct 22, 2024 via email

@postlund
Copy link
Owner

There probably is, I just found mediafile very convenient to use. It's just only used extract some metadata from audio files, e.g. artist, title and such. So it should be fairly easy to replace.

@postlund
Copy link
Owner

This one is a contender: https://github.com/tinytag/tinytag

@postlund
Copy link
Owner

I'm working on migrating to tiny tag, will try to finish off of this weekend.

postlund added a commit that referenced this issue Nov 2, 2024
postlund added a commit that referenced this issue Nov 2, 2024
postlund added a commit that referenced this issue Nov 2, 2024
postlund added a commit that referenced this issue Nov 2, 2024
postlund added a commit that referenced this issue Nov 2, 2024
postlund added a commit that referenced this issue Nov 2, 2024
postlund added a commit that referenced this issue Nov 2, 2024
postlund added a commit that referenced this issue Nov 2, 2024
postlund added a commit that referenced this issue Nov 2, 2024
postlund added a commit that referenced this issue Nov 2, 2024
postlund added a commit that referenced this issue Nov 2, 2024
@postlund
Copy link
Owner

postlund commented Nov 2, 2024

This should be fixed by #2532, which is merged now. I have a few more things I want to get merged, so I will fix that and make a release once everything is ready. Let's see if I can make it within the next few days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants