Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to use async/await in NodeJS Axios #677

Merged
merged 4 commits into from
Feb 27, 2023
Merged

Add option to use async/await in NodeJS Axios #677

merged 4 commits into from
Feb 27, 2023

Conversation

dhwaneetbhatt
Copy link
Contributor

  • Remove ES6_enabled as there is universal support for let/const and arrow functions now
  • Added a new option, asyncAwaitEnabled, to make an Axios request using await
  • Made the code compatible with the latest version of Axios
  • Removed bundled lodash and added dependency on latest lodash
  • Follow Redirects now also reads it from request settings (like cURL)
  • Replaced var with let/const in the code

Tested locally by loading the feature branch in postman app.

@dhwaneetbhatt dhwaneetbhatt self-assigned this Feb 23, 2023
@dhwaneetbhatt dhwaneetbhatt merged commit b427e61 into develop Feb 27, 2023
@dhwaneetbhatt dhwaneetbhatt deleted the feature/nodejs-axios-use-async-await branch February 27, 2023 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@webholik webholik webholik approved these changes

Assignees

@dhwaneetbhatt dhwaneetbhatt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dhwaneetbhatt @webholik