Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added exception handlers when removing listeners from http2 sockets #95

Merged
merged 1 commit into from
Jul 26, 2024

Conversation

parthverma1
Copy link

PR Checklist:

  • I have run npm test locally and all tests are passing.
  • I have added/updated tests for any new behavior.
  • If this is a significant change, an issue has already been created where the problem / solution was discussed: [N/A, or add link to issue here]

PR Description

Added try-catch to prevent ERR_HTTP2_SOCKET_UNBOUND from bubbling up. This happens when the main execution tries to remove listeners from the socket, but if the stream has errored out, the socket is disassociated with the session and hence the error.

@codenirvana codenirvana merged commit c3bfa18 into master Jul 26, 2024
4 checks passed
@codenirvana codenirvana deleted the feature/unbound-socket-error-http2 branch July 26, 2024 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants