Added support for accessing execution location through script #1336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vedkribhu
force-pushed
the
feat/add-path
branch
3 times, most recently
from
8173e3a to
0266d96
Compare
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #1336 +/- ##
============================================
- Coverage 78.73% 42.30% -36.44%
============================================
Files 45 45
Lines 3316 3319 +3
Branches 947 950 +3
============================================
- Hits 2611 1404 -1207
- Misses 705 1915 +1210
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
coditva
reviewed
Oct 9, 2023
coditva
reviewed
Oct 9, 2023
coditva
reviewed
Oct 9, 2023
vedkribhu
force-pushed
the
feat/add-path
branch
from
0266d96 to
4acceff
Compare
vedkribhu
changed the title
coditva
reviewed
Oct 11, 2023
Comment on lines
801
to
861
| it(`should have path as correct path for a request nested inside folder when printed from | ||
| pre-request script of collection`, function () { |
There was a problem hiding this comment.
What is the convention in this repo? Should test names contain a newline?
Suggested change
| it(`should have path as correct path for a request nested inside folder when printed from | |
| pre-request script of collection`, function () { | |
| it( | |
| 'should have path as correct path for a request nested inside folder when printed from pre-request script of collection', | |
| function () { |
There was a problem hiding this comment.
@codenirvana can guide here, not able to find more such instances.
vedkribhu
force-pushed
the
feat/add-path
branch
2 times, most recently
from
1035516 to
4acc8d0
Compare
|
Need to update the |
vedkribhu
force-pushed
the
feat/add-path
branch
2 times, most recently
from
87f6dc5 to
b9bae6b
Compare
vedkribhu
force-pushed
the
feat/add-path
branch
4 times, most recently
from
352f923 to
7b9b062
Compare
coditva
reviewed
Nov 16, 2023
vedkribhu
force-pushed
the
feat/add-path
branch
from
7b9b062 to
8726b9d
Compare
coditva
reviewed
Nov 17, 2023
coditva
reviewed
Nov 17, 2023
| @@ -457,6 +457,8 @@ module.exports = { | |||
| shouldSkipExecution = true; | |||
| }); | |||
|
|
|||
| const currentEventItem = event.parent && event.parent(); | |||
There was a problem hiding this comment.
Can we add comment about why the current item is .parent?
appurva21
changed the title
appurva21
previously approved these changes
Nov 18, 2023
codenirvana
approved these changes
Nov 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.