Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python API using Python CFFI #253

Merged
merged 68 commits into from
Dec 29, 2020
Merged

Python API using Python CFFI #253

merged 68 commits into from
Dec 29, 2020

Conversation

rkaminsk
Copy link
Member

@rkaminsk rkaminsk commented Dec 14, 2020

  • set python version via definition
  • fix remaining pylint messages
  • add install target for python library
  • find a nice way to handle the path in embedded pyclingo
    • there should be a path to be able to run clingo without installing
    • otherwise, it is probably best to not set a path
  • handle visibility of declarations in embedded pyclingo
    • I did not find a way to change visibility without manually editing the files.
    • Currently, the cmake files contain a crude workaround to make it link on Windows.
    • Embedding does also not work nicely on Windows because some paths are missing.
      They can be set manually and and at least the python module works nicely.
    • This might need further fine-tuning (or maybe disable embedding on Windows).
  • improve documentation
    • Python documentation
    • C documentation
  • create pip package
    • try to reuse the code from the pip branch to do this
  • Create C++ bindings for new AST API.
    • implement bindings
    • add more tests
  • Implement unpooling (or maybe later).

@rkaminsk rkaminsk changed the title Python API using python cffi Python API using Python cffi Dec 14, 2020
@rkaminsk rkaminsk marked this pull request as ready for review December 29, 2020 11:37
@rkaminsk rkaminsk added this to the v5.5.0 milestone Dec 29, 2020
@rkaminsk rkaminsk merged commit 70d4ac9 into wip Dec 29, 2020
@rkaminsk rkaminsk deleted the refactor/ast branch December 29, 2020 14:50
@rkaminsk rkaminsk linked an issue Dec 30, 2020 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Packaging clingo with pip
1 participant