Skip to content

Commit

Permalink
Temporarily limit botocore upgrades
Browse files Browse the repository at this point in the history
The latest botocore (1.29.127) breaks the way moto creates SQS
queues and we need to limit it temporarily so that it will not
fail our tests.

Related: getmoto/moto#6286
Related: i#31087
  • Loading branch information
potiuk committed May 5, 2023
1 parent 9e43d4a commit a11a3ca
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 2 deletions.
5 changes: 4 additions & 1 deletion Dockerfile.ci
Original file line number Diff line number Diff line change
Expand Up @@ -1132,7 +1132,10 @@ if [[ ${UPGRADE_BOTO=} == "true" ]]; then
echo "${COLOR_BLUE}Upgrading boto3, botocore to latest version to run Amazon tests with them${COLOR_RESET}"
echo
pip uninstall aiobotocore -y || true
pip install --upgrade boto3 botocore
# Temporarily limit upgrade of botocore to be less than 1.29.127
# in order to avoid failing on SQS tests
# See https://github.com/getmoto/moto/issues/6286 and https://github.com/apache/airflow/issues/31087
pip install --upgrade boto3 "botocore<1.29.127"
fi
readonly SELECTED_TESTS CLI_TESTS API_TESTS PROVIDERS_TESTS CORE_TESTS WWW_TESTS \
ALL_TESTS ALL_PRESELECTED_TESTS
Expand Down
5 changes: 4 additions & 1 deletion scripts/docker/entrypoint_ci.sh
Original file line number Diff line number Diff line change
Expand Up @@ -562,7 +562,10 @@ if [[ ${UPGRADE_BOTO=} == "true" ]]; then
echo "${COLOR_BLUE}Upgrading boto3, botocore to latest version to run Amazon tests with them${COLOR_RESET}"
echo
pip uninstall aiobotocore -y || true
pip install --upgrade boto3 botocore
# Temporarily limit upgrade of botocore to be less than 1.29.127
# in order to avoid failing on SQS tests
# See https://github.com/getmoto/moto/issues/6286 and https://github.com/apache/airflow/issues/31087
pip install --upgrade boto3 "botocore<1.29.127"
fi
readonly SELECTED_TESTS CLI_TESTS API_TESTS PROVIDERS_TESTS CORE_TESTS WWW_TESTS \
ALL_TESTS ALL_PRESELECTED_TESTS
Expand Down

0 comments on commit a11a3ca

Please sign in to comment.