Ensure test failures

[reconbot]

The double expect and the return instead of throw wasn't working.

[gr2m]

looks good to me but would like another review to make sure I’m not missing anything

[reconbot]

I did some more research and testing with superTest and figure out that it's promise compatible in the sense that you can call then instead of end. I also saw that I was throwing an incorrect message.

[reconbot]

The superTest expect(function() {}) doesn't pass non errors to done(). Returning strings, and throwing strings don't work. I tested each modified test to see if it would really fail and they wouldn't. But with these changes, now they do.

[gr2m]

@reconbot any reason why we wouldn’t adapt the same convention for all tests that use supertest?

[reconbot]

We should do just that - I only addressed the unit tests in this PR

[gr2m]

we only use tests/express-pouchdb/test.js right now. But we can make it in a follow up PR, too.

It’s been open for a week now, I’d say we go ahead and merge it in if you are ready from your side?

[garrensmith]

Great thanks.