Finish monorepo merge: http-pouchdb #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Version 1.1.1
Update pouchdb to version 6.1.1 🚀
Update mocha to version 3.2.0 🚀
Update browserify to version 14.0.0 🚀
gr2m
commented
Jun 26, 2017
| @@ -68,7 +68,8 @@ | |||
| "serve-favicon": "~2.3.2", | |||
| "tail": "^1.2.1", | |||
| "uuid": "^3.0.1", | |||
| "wordwrap": "1.0.0" | |||
| "wordwrap": "1.0.0", | |||
| "xhr2": "^0.1.3" | |||
There was a problem hiding this comment.
xhr2 is a new dependency for http-pouchdb: https://github.com/pouchdb/http-pouchdb/blob/9b28231f2c40795c045956a6a4b0f3f974c661c9/package.json#L51
|
|
||
| return users.info().then(function (info) { | ||
| info.should.have.property('db_name'); | ||
| }); |
There was a problem hiding this comment.
the constructor tests are different from the original: https://github.com/pouchdb/http-pouchdb/blob/9b28231f2c40795c045956a6a4b0f3f974c661c9/test/test.js#L25-L39
- For the unit tests, we start our own
pouchdb-serverso thedata_sizedoes not exist, hence I just check fordb_name
-new HTTPPouchDB('http://localhost:5984/_replicator')is valid with the latest PouchDB, it just encodes all the slashes etc. If that is an error, it’s outside of the scope ofhttp-pouchdb
|
@gr2m Awesome +1 |
garrensmith
approved these changes
Jun 26, 2017
|
thanks for the review @garrensmith, I’ll move forward then :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of #197