Reduce array_merge call in case exclude-path or exclude-files passed …

…by user (#170)

src/Command/RunCommand.php

@@ -227,16 +227,10 @@ private function getCSVOption(InputInterface $input, string $option): array
             return [];
         }
 
-        if (false === is_array($result)) {
-            return array_filter(
-                explode(',', (string) $result),
-                static function ($value) {
-                    return false === empty($value);
-                }
-            );
+        if (!is_array($result)) {
+            return array_filter(explode(',', (string) $result));
         }
 
-
         return $result;
     }
 

src/Console/Application.php

@@ -46,11 +46,11 @@ public function doRun(InputInterface $input, OutputInterface $output): int
 
     public function getLongVersion(): string
     {
-        return trim(sprintf(
+        return sprintf(
             '<info>%s</info> version <comment>%s</comment> by Povilas Susinskas',
             $this->getName(),
             $this->getVersion()
-        ));
+        );
     }
 
     public function getContainer(): Container

src/PHPFinder.php

@@ -26,25 +26,19 @@ public function __construct(
             ->exclude(array_merge(['vendor'], $exclude))
             ->ignoreDotFiles(true)
             ->ignoreVCS(true)
+            ->notPath($excludePaths)
+            ->notName($excludeFiles)
+            ->name(
+                array_map(
+                    static fn (string $suffix) => '*.' . $suffix,
+                    $suffixes
+                )
+            )
             ->append(
                 array_map(
-                    function (string $file) {
-                        return new SplFileInfo(realpath($file), dirname($file), $file);
-                    },
+                    static fn (string $file) => new SplFileInfo(realpath($file), dirname($file), $file),
                     $files
                 )
             );
-
-        foreach ($suffixes as $suffix) {
-            $this->name('*.' . $suffix);
-        }
-
-        foreach ($excludePaths as $notPath) {
-            $this->notPath($notPath);
-        }
-
-        foreach ($excludeFiles as $notName) {
-            $this->notName($notName);
-        }
     }
 }

tests/Command/RunCommandTest.php

@@ -64,4 +64,16 @@ public function testItDoesNotFailCommandWhenFileOnPathDoesNotExist(): void
         $this->assertSame(RunCommand::SUCCESS, $this->commandTester->getStatusCode());
         $this->assertStringContainsString('No files found to scan', $this->commandTester->getDisplay());
     }
+
+    public function testFilterBySuffixes(): void
+    {
+        $this->commandTester->execute([
+            'directories' => ['tests/Fixtures/Files'],
+            '--extensions' => 'all',
+            '--suffixes' => 'php5',
+        ]);
+
+        $this->assertSame(RunCommand::FAILURE, $this->commandTester->getStatusCode());
+        $this->assertStringContainsString('Total of Magic Numbers: 1', $this->commandTester->getDisplay());
+    }
 }

tests/Fixtures/Files/test_4.php5

@@ -0,0 +1,3 @@
+<?php
+
+$variable_0 = 123;