Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add API guide #247

Merged
merged 1 commit into from
Aug 11, 2019
Merged

Add API guide #247

merged 1 commit into from
Aug 11, 2019

Conversation

danschultzer
Copy link
Collaborator

@danschultzer danschultzer commented Aug 10, 2019 •
edited
Loading

Resolves #176

@popo63301
Copy link
Contributor

Amazing ! 😍

@danschultzer
Copy link
Collaborator Author

@popo63301 🚀 feel free to test it out and comment! I haven't tested the code yet, but will do it soon (and I would like to add some copy-paste test modules too)

@popo63301
Copy link
Contributor

popo63301 commented Aug 10, 2019 •
edited
Loading

Sure ! I'll give a try soon. I'm wondering though why the code is not part of the library itself rather than the API guide. Or maybe that's the next step?

@danschultzer
Copy link
Collaborator Author

Yeah, I attempt to limit the working parts in Pow as much as possible and instead just make it easy to customize. So the best way to go about this is first a guide, and then maybe take parts of that and implement into Pow to make it easier. However, for API I do believe it's better if the dev writes it out completely to have full control of how the API responses look.

@danschultzer danschultzer force-pushed the api-guide branch 5 times, most recently from 4a1448e to 1886c44 Compare August 10, 2019 22:12
@danschultzer
Copy link
Collaborator Author

Ok, I think it's ready now. I've added test modules, and tested it out myself 🚀

@danschultzer danschultzer marked this pull request as ready for review August 10, 2019 22:25
@popo63301
Copy link
Contributor

Great ! Thanks for your amazing work Dan ! Pow is going to be the way to go for Phoenix authentication ! 😎

@danschultzer danschultzer merged commit abe58b0 into master Aug 11, 2019
@danschultzer danschultzer deleted the api-guide branch August 11, 2019 00:02
@danschultzer danschultzer mentioned this pull request Aug 15, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

API integration guide
2 participants
@danschultzer @popo63301