Refactor e-mail validation #257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danschultzer
force-pushed
the
email-validation
branch
from
f61247f
to
50b7fda
Compare
danschultzer
force-pushed
the
email-validation
branch
from
50b7fda
to
996f7c6
Compare
|
Edit: I looked up a billion different ways of doing it, everything from pretty much no validation, to very complex regex. Then I checked the wikipedia page, and decided to just build a validator based on those assumptions with unicode acceptance. |
danschultzer
force-pushed
the
email-validation
branch
from
3dc6aba
to
221908e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #253
Makes email validation configurable with
:email_validatorconfiguration option.