Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only filter routes with same number of bindings #292

Merged
merged 1 commit into from
Oct 9, 2019

Conversation

danschultzer
Copy link
Collaborator

Resolves #291

When a route exists with the same helper alias and controller action, the length of bindings will also be checked. This ensure that the following won't be filtered out:

  scope "/" do
    pipe_through [:browser]

    pow_routes()
    pow_extension_routes()
    pow_assent_routes()
  end

  scope "/:locale" do
    pipe_through [:browser]

    pow_routes()
    pow_extension_routes()
    pow_assent_routes()
  end

The first set of helper aliases in the above is different from the second set so there are no conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Keeping scope in generated routes
1 participant