Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only permit GET method for request_path param #303

Merged
merged 1 commit into from
Oct 18, 2019

Conversation

danschultzer
Copy link
Collaborator

This prevents paths that doesn't use GET method from being used such as POST and DELETE since the path is used for redirects which can only be handled with GET method.

Copy link
Contributor

@Schultzer Schultzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

test/support/phoenix/controller_assertions.ex Outdated Show resolved Hide resolved
@danschultzer danschultzer merged commit 2606d81 into master Oct 18, 2019
@danschultzer danschultzer deleted the request-path-get-method branch October 18, 2019 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants