Refactor extension discovery and add base module for all extensions #335
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #329
This may supersede #333
With this PR a base module is now expected in an extension that will clearly describe what the extension supports. This should prevent pretty much all
Code.ensure_compiled?/1
calls, but is still backwards compatible.For extensions missing the base module a warning will be printed with
no MyCustomModule base module to check for ["Ecto", "Schema"] support found, please use Pow.Extension.Base to implement it
).A base module would look like this: