Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call custom get_by/2 context method #343

Merged
merged 1 commit into from
Jan 10, 2020
Merged

Call custom get_by/2 context method #343

merged 1 commit into from
Jan 10, 2020

Conversation

danschultzer
Copy link
Collaborator

@danschultzer danschultzer commented Nov 29, 2019

#308 (comment) is not possible with how Pow currently handles custom context. This is a potential solution, but I'll work a bit more on it as I'm not sure if it makes sense to call Operations module rather than handle custom context in the context module itself.

Resolves #371

@nenros
Copy link

nenros commented Nov 29, 2019

👍

@danschultzer danschultzer force-pushed the get-by-refactor branch 3 times, most recently from df3953b to 894dd75 Compare January 9, 2020 23:48
@danschultzer danschultzer marked this pull request as ready for review January 9, 2020 23:54
@danschultzer danschultzer force-pushed the get-by-refactor branch 3 times, most recently from 1141f08 to 89f6f7d Compare January 10, 2020 00:44
@danschultzer danschultzer merged commit 34ef128 into master Jan 10, 2020
@danschultzer danschultzer deleted the get-by-refactor branch January 10, 2020 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Session plug ignores custom get_by
2 participants