Add after compile validation check to ensure all fields and assocs have been defined #376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danschultzer
force-pushed
the
ecto-after-compile
branch
2 times, most recently
from
d60de2c
to
5aa502a
Compare
danschultzer
force-pushed
the
ecto-after-compile
branch
3 times, most recently
from
f18e376
to
4d25d31
Compare
danschultzer
force-pushed
the
ecto-after-compile
branch
from
4d25d31
to
f9c4c4c
Compare
danschultzer
force-pushed
the
ecto-after-compile
branch
from
f9c4c4c
to
510fbfd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on suggestion by @josevalim.
This adds an
@after_compilevalidation check to ensure all assocs and fields used by Pow and its extensions has been defined. This way devs are no longer dependent on usingpow_user_fields/0, asPow.Ecto.Schemawill raise an error on compile-time to ensure all fields are defined.This paves the road to get rid of
pow_user_fields/0and let devs explicitly list all assocs and fields. The thing that holds me back is to still keep Pow super easy to set up. If the assocs and fields have to be explicitly listed, then adding extensions would require additional steps to get working.