Prevent user enumeration attacks #384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danschultzer
force-pushed
the
prevent-info-leak
branch
2 times, most recently
from
f85902e
to
eec7603
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #383 and refactors code from #350.
The logic has been refactored to rely more on a
:pow_prevent_information_leakprivate key inconnso the dev can decide which routes/situations that info leak is permitted.Since it's not really possible to prevent enumeration attacks unless
PowEmailConfirmationhas been enabled, the logic lies there currently, but I'll try to see if I can refactor it further and maybe move it to the base extension modules, or Pow core. Previously I checked whether registration paths where disabled, since it would prevent user enumeration attacks for Pow core.Edit: Updated to move some of the logic out of
PowEmailConfirmation, and opted for policy to prevent info leak by default.