Refactor primary key clauses handling #393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danschultzer
force-pushed
the
refactor-clauses-handling
branch
from
24ab5ce
to
841b93d
Compare
danschultzer
force-pushed
the
refactor-clauses-handling
branch
from
841b93d
to
6b05abc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved this out of #392. It makes sense to move primary key logic over to operations instead of handling it in other module groups. With this, there is no expectation of certain structure for the user struct in the Plug/Phoenix/Store modules except for the clauses validation step in
PowPersistentSession.Plug.Cookie.