Remove Phoenix.View requirement #691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor Pow mailer
danschultzer
force-pushed
the
phoenix-view
branch
from
f1652a5
to
e388c56
Compare
danschultzer
force-pushed
the
phoenix-view
branch
from
e388c56
to
1d8714d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the requirement for
Phoenix.View. There's a large revamp of the mailer to make it all contained within Pow rather than depend on Phoenix to render. This also updates everything to conform to the Phoenix 1.7 component templating. Last thing to do is to update templates to tailwind and figure out CoreComponents integration (likely requires a fallback in Pow).