CI: Add back clippy & fmt checks #661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
georgwiese
force-pushed
the
fix-clippy
branch
2 times, most recently
from
6d485ae to
0c3df98
Compare
georgwiese
commented
Oct 4, 2023
chriseth
reviewed
Oct 4, 2023
.github/workflows/pr-tests.yml
Outdated
| - name: Install nightly | ||
| run: rustup toolchain install nightly-2023-01-03-x86_64-unknown-linux-gnu | ||
| - name: Install riscv target | ||
| run: rustup target add riscv32imac-unknown-none-elf --toolchain nightly-2023-01-03-x86_64-unknown-linux-gnu | ||
| - name: Install stdlib | ||
| run: rustup component add rust-src --toolchain nightly-2023-01-03-x86_64-unknown-linux-gnu | ||
| - name: Lint | ||
| run: cargo clippy --all --all-features -- -D warnings |
There was a problem hiding this comment.
Is it more performant to group the calls with --all-features and --no-default-features, so that it does not have to go back-and-forth?
|
Looks good! Why did you move clippy? |
chriseth
previously approved these changes
Oct 4, 2023
georgwiese
force-pushed
the
fix-clippy
branch
2 times, most recently
from
72a217d to
7c25760
Compare
chriseth
approved these changes
Oct 4, 2023
I think my hope was to reuse some work, but I think it doesn't make much of a difference. But now the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clippy and fmt checks got (I think accidentally) removed in #624. This PR adds them back.