Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking Change: update to Babel 6 & babel-plugin-espower 2.0 #22

Merged
merged 7 commits into from
Nov 13, 2015
Merged

Conversation

azu
Copy link
Member

@azu azu commented Nov 13, 2015

Babel 6 has many many breaking changes.
So, to update to Babel 6 and espower-babel break backword compatible too.

Ref:
https://github.com/power-assert-js/babel-plugin-espower/releases/tag/v2.0.0
http://babeljs.io/blog/2015/10/29/6.0.0/

close #21

@azu
Copy link
Member Author

azu commented Nov 13, 2015

done.

@twada please review it 🙇

}
})
```

**Caution**:

Babel 6 has not transform by default.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Babel 6 does not transform your code by default. ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed


```js
require('espower-babel')({
babelrc: {
stage: 0
"presets": ["es2015", "stage-3"],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

presets might be different among users so I've omitted the presets part in README.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'v added e.g.) to above of the example.
(I like copy-pastable exampe)

@azu
Copy link
Member Author

azu commented Nov 13, 2015

real example work fine!

@twada
Copy link
Member

twada commented Nov 13, 2015

Okay, LGTM!!

azu added a commit that referenced this pull request Nov 13, 2015
Breaking Change: update to Babel 6 & babel-plugin-espower 2.0
@azu azu merged commit ccf15ce into master Nov 13, 2015
@azu azu deleted the babel6 branch November 13, 2015 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

An error on babel6
2 participants