Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yarn workspace dependencies #81

Merged
merged 5 commits into from
Aug 17, 2022
Merged

Yarn workspace dependencies #81

merged 5 commits into from
Aug 17, 2022

Conversation

xjunior
Copy link
Contributor

@xjunior xjunior commented Aug 13, 2022

Yarn workspaces expect dependency versions to match the specified in package.json. When they don't match, the dependencies fall onto the unmatchedWorkspaceDependency sections. This PR aims to work closer to the yarn workspaces specification. When the version matches, yarn workspaces is responsible for linking them automatically.

This PR also refactors the workspace implementation in a way that avoids prematurely reading all workspace package.yml files.

Before:

time be cobra ls --js --app /Users/chjunior/workspace/power/nitro-web -t
70
bundle exec cobra ls --js --app /Users/chjunior/workspace/power/nitro-web -t  2.09s user 0.82s system 91% cpu 3.178 total

After:

time be ./exe/cobra ls --js --app /Users/chjunior/workspace/power/nitro-web -t
70
bundle exec ./exe/cobra ls --js --app  -t  0.45s user 0.35s system 68% cpu 1.174 total

@xjunior xjunior force-pushed the yarn-workspace-dependencies branch from 60bdac9 to 8d5c86b Compare August 16, 2022 18:43
@xjunior xjunior merged commit 77b5830 into main Aug 17, 2022
@xjunior xjunior deleted the yarn-workspace-dependencies branch August 17, 2022 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants